Web: Don't stop tracks when disposing MediaStream (flutter-webrtc#760)

hiroshihorie · web-flow · commit 16046891cbab · 2021-11-10T23:14:43.000+08:00
* don't call `stop` on tracks when disposing

* not `RTCVideoRendererWeb`'s responsibility to dispose `srcObject`
diff --git a/lib/src/web/media_stream_impl.dart b/lib/src/web/media_stream_impl.dart
@@ -52,14 +52,6 @@ class MediaStreamWeb extends MediaStream {
     return audioTracks;
   }
 
-  @override
-  Future<void> dispose() async {
-    getTracks().forEach((element) {
-      element.stop();
-    });
-    return super.dispose();
-  }
-
   @override
   List<MediaStreamTrack> getTracks() {
     return <MediaStreamTrack>[...getAudioTracks(), ...getVideoTracks()];
diff --git a/lib/src/web/media_stream_track_impl.dart b/lib/src/web/media_stream_track_impl.dart
@@ -81,9 +81,7 @@ class MediaStreamTrackWeb extends MediaStreamTrack {
   }
 
   @override
-  Future<void> dispose() async {
-    return stop();
-  }
+  Future<void> dispose() async {}
 
   @override
   Future<void> stop() async {
diff --git a/lib/src/web/rtc_video_renderer_impl.dart b/lib/src/web/rtc_video_renderer_impl.dart
@@ -160,7 +160,6 @@ class RTCVideoRendererWeb extends VideoRenderer {
 
   @override
   Future<void> dispose() async {
-    await _srcObject?.dispose();
     _srcObject = null;
     _subscriptions.forEach((s) => s.cancel());
     final element = findHtmlView();

Original file line number	Diff line number	Diff line change
`@@ -81,9 +81,7 @@ class MediaStreamTrackWeb extends MediaStreamTrack {`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`@override`
`84`		`- Future<void> dispose() async {`
`85`		`- return stop();`
`86`		`- }`
	`84`	`+ Future<void> dispose() async {}`
`87`	`85`
`88`	`86`	`@override`
`89`	`87`	`Future<void> stop() async {`