-
Notifications
You must be signed in to change notification settings - Fork 28.9k
Closed
Task
Copy link
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.infra: recipesIssues with flutter/recipesIssues with flutter/recipesteam-infraOwned by Infrastructure teamOwned by Infrastructure team
Description
The following line was updated to recipes/release/release_builder.py
in 2d1e37419fd94e89c0dbbb2a0a86b9e337c48ddc
:
def ShouldRun(api, git_ref, target, release_branch):
"""Validates if a target should run based on platform, channel and repo."""
# Enabled for current branch
enabled_branches = target.get('enabled_branches', [])
- if enabled_branches:
+ if enabled_branches and target.get('scheduler') != 'release':
This was to work around some issue poorly explained in #128459.
CL: https://flutter-review.googlesource.com/c/recipes/+/45564/2/recipes/release/release_builder.py#45.
I believe we could remove this line by adding the following to .ci.yaml
targets:
- name: Linux flutter_packaging
recipe: packaging/packaging
timeout: 60
scheduler: release
bringup: true # https://github.com/flutter/flutter/issues/126286
enabled_branches:
- beta
- stable
+ - flutter-\d+\.\d+-candidate\.\d+
properties:
task_name: flutter_packaging
tags: >
["framework", "hostonly", "shard", "linux"]
drone_dimensions:
- os=Linux
Note that this change would have to be cherrypicked to active release branches as well.
Metadata
Metadata
Assignees
Labels
P2Important issues not at the top of the work listImportant issues not at the top of the work listc: tech-debtTechnical debt, code quality, testing, etc.Technical debt, code quality, testing, etc.infra: recipesIssues with flutter/recipesIssues with flutter/recipesteam-infraOwned by Infrastructure teamOwned by Infrastructure team