8000 Flutter web @ 3.29 stable double loads canvaskit.wasm when running with JS · Issue #163250 · flutter/flutter · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter web @ 3.29 stable double loads canvaskit.wasm when running with JS #163250

Open
kevmoo opened this issue Feb 13, 2025 · 5 comments
Open

Flutter web @ 3.29 stable double loads canvaskit.wasm when running with JS #163250

kevmoo opened this issue Feb 13, 2025 · 5 comments
Labels
found in release: 3.29 Found to occur in 3.29 P1 High-priority issues at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team

Comments

@kevmoo
Copy link
Contributor
kevmoo commented Feb 13, 2025

See https://flutter.github.io/samples/web/material_3_demo/ on Firefox and Safari (with JS)

Does not happen on Chrome (with Wasm)
@kevmoo kevmoo added P1 High-priority issues at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team found in release: 3.29 Found to occur in 3.29 labels Feb 13, 2025
@kevmoo
Copy link
Contributor Author
kevmoo commented Feb 13, 2025

CC @yjbanov @eyebrowsoffire

@eyebrowsoffire
Copy link
Contributor

I am fairly certain Harry incidentally fixed this in #162198

In particular it's the sINCOMING_MODULE_JS_API change. We could consider cherry-picking that.

@kevmoo
Copy link
Contributor Author
kevmoo commented Feb 13, 2025

How easy is it to confirm that fix on stable? Should I just do the cp: stable label on that PR?

@yjbanov
Copy link
Contributor
yjbanov commented Feb 13, 2025 •
edited
Loading

The second fetch comes from the cache, so I think if there's no other overhead, this is probably OK?

This is a recording from Firefox:

Image

@kevmoo
Copy link
Contributor Author
kevmoo commented Feb 13, 2025

Not on safari:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
found in release: 3.29 Found to occur in 3.29 P1 High-priority issues at the top of the work list platform-web Web applications specifically team-web Owned by Web platform team triaged-web Triaged by Web platform team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @yjbanov @eyebrowsoffire
0