8000 [CP-beta]Remove `docs_deploy_beta`, fix `docs_publish`, add comments.… · flutter/flutter@c4f885d · GitHub
[go: up one dir, main page]

Skip to content

Commit c4f885d

Browse files
[CP-beta]Remove docs_deploy_beta, fix docs_publish, add comments. (#168824)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? Closes #168709. ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples N/A (CI Infra Change) ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Not user facing - this fixes API doc generation for release candidate branches, which was accidentally broken in #162557. ### Workaround: Is there a workaround for this issue? N/A ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? Merge a commit to `flutter-3.32-candidate.0` and observe the post-submits.
1 parent dbc3660 commit c4f885d

File tree

1 file changed

+16
-30
lines changed

1 file changed

+16
-30
lines changed

.ci.yaml

Lines changed: 16 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -582,19 +582,25 @@ targets:
582582
# tests are sharded.
583583
test_timeout_secs: "3600" # Allows 60 minutes (up from 30 default)
584584

585+
# Despite the name, this really means "generate api_docs.zip", and "upload zip
586+
# to GCS", and conditionally on the "master" channel will also deploy the docs
587+
# to Firebase (https://main-api.flutter.dev/).
588+
#
589+
# See "Linux docs_deploy_stable" for how the docs are deployed to stable API.
585590
- name: Linux docs_publish
586591
recipe: flutter/docs
587592
presubmit: false
588593
backfill: false
594+
# This means "allow this to be scheduled by the release/release_builder"
595+
# recipe. Normally we'd use "schedule: true", but that *also* means "do not
596+
# run this in normal presubmit/postsubmit", and we do want it to run in
597+
# postsubmit for the "master" channel. Sorry.
598+
#
599+
# See https://github.com/flutter/flutter/issues/168709 for details.
600+
schedule_during_release_override: true
589601
timeout: 60
590602
dimensions:
591603
os: "Linux"
592-
enabled_branches:
593-
# Produces docs for main-api.flutter.dev
594-
# stable and beta are managed by the targets:
595-
# - Linux docs_deploy_beta
596-
# - Linux docs_deploy_stable
597-
- master
598604
properties:
599605
cores: "32"
600606
dependencies: >-
@@ -6915,30 +6921,10 @@ targets:
69156921
drone_dimensions:
69166922
- os=Windows
69176923

6918-
6919-
- name: Linux docs_deploy_beta
6920-
recipe: flutter/docs
6921-
scheduler: release
6922-
bringup: true
6923-
enabled_branches:
6924-
- beta
6925-
presubmit: false
6926-
timeout: 60
6927-
properties:
6928-
cores: "32"
6929-
dependencies: >-
6930-
[
6931-
{"dependency": "dashing", "version": "0.4.0"},
6932-
{"dependency": "firebase", "version": "v11.0.1"}
6933-
]
6934-
tags: >
6935-
["framework", "hostonly", "linux"]
6936-
validation: docs_deploy
6937-
validation_name: Docs_deploy
6938-
firebase_project: master-docs-flutter-dev
6939-
drone_dimensions:
6940-
- os=Linux
6941-
6924+
# This step runs on the release channel "stable", after the same commit SHA
6925+
# has been run and built by Linux flutter_release_builder as part of a release
6926+
# candidate branch (i.e. /flutter-\d+\.\d+-candidate\.\d+/) in the previous
6927+
# target, "Linux docs_publish".
69426928
- name: Linux docs_deploy_stable
69436929
recipe: flutter/docs
69446930
scheduler: release

0 commit comments

Comments
 (0)
0