8000 [stable] Roll `package:dds` to 5.0.2 (#169471) (#169515) · flutter/flutter@80f085c · GitHub
[go: up one dir, main page]
Skip to content

Commit 80f085c

Browse files
bkonyibkonyi
authored
[stable] Roll package:dds to 5.0.2 (#169471) (#169515)
Fixes #156793 ### Issue Link: #156793 ### Changelog Description: Fix flaky crash when targeting web applications via IDEs using the DAP. ### Impact Description: The `flutter debug-adapter` process started by IDEs can crash when requesting isolate information from a Flutter web application that has disposed its isolate (i.e., at shutdown or due to a hot restart). This is the top crasher for `flutter_tools`, accounting for ~66% of all crashes for 3.32.0. ### Workaround: Is there a workaround for this issue? No. ### Risk: This CP is low risk as only additional exception handling was added to the DAP logic in `package:dds` (see https://dart-review.googlesource.com/c/sdk/+/431060) to handle the specific case outlined in the issue. ### Test Coverage: This issue is difficult to reproduce without injecting test-only code via custom VM service RPCs across multiple repositories. Testing was done manually with this approach, but the testing code is not committed. ### Validation Steps: IDE extensions don't crash when interacting with Flutter Web applications during hot restart / application shutdown.
1 parent 9057717 commit 80f085c

File tree

3 files changed

+23
-15
lines changed

3 files changed

+23
-15
lines changed

‎CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,10 @@ INTERNAL NOTE
2929

3030
## Flutter 3.32 Changes
3131

32+
### [3.32.1](https://github.com/flutter/flutter/releases/tag/3.32.1)
33+
34+
- [flutter/156793](https://github.com/flutter/flutter/issues/156793) - Fix flaky crash when targeting web applications via IDEs using the DAP.
35+
3236
### [3.32.0](https://github.com/flutter/flutter/releases/tag/3.32.0)
3337
Initial stable release.
3438

‎packages/flutter_tools/pubspec.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ dependencies:
1212
# https://github.com/flutter/flutter/blob/main/docs/infra/Updating-dependencies-in-Flutter.md
1313
archive: 3.6.1
1414
args: 2.7.0
15-
dds: 5.0.0
15+
dds: 5.0.2
1616
dwds: 24.3.10
1717
code_builder: 4.10.1
1818
completion: 1.0.1
@@ -78,7 +78,7 @@ dependencies:
7878
csslib: 1.0.2 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
7979
dap: 1.4.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
8080
dds_service_extensions: 2.0.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
81-
devtools_shared: 11.2.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
81+
devtools_shared: 11.2.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
8282
dtd: 2.5.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
8383
extension_discovery: 2.1.0 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
8484
fixnum: 1.1.1 # THIS LINE IS AUTOGENERATED - TO UPDATE USE "flutter update-packages --force-upgrade"
@@ -122,4 +122,4 @@ dartdoc:
122122
# Exclude this package from the hosted API docs.
123123
nodoc: true
124124

125-
# PUBSPEC CHECKSUM: c093
125+
# PUBSPEC CHECKSUM: 7396

‎packages/flutter_tools/test/integration.shard/debug_adapter/flutter_adapter_test.dart

Lines changed: 16 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -272,16 +272,18 @@ The relevant error-causing widget was:
272272
);
273273
});
274274

275-
testWithoutContext('correctly outputs colored exceptions when supported', () async {
276-
final BasicProjectThatThrows project = BasicProjectThatThrows();
277-
final String output = await getExceptionOutput(project, noDebug: false, ansiColors: true);
278-
279-
// Frames in the stack trace that are the users own code will be unformatted, but
280-
// frames from the framework are faint (starting with `\x1B[2m`).
281-
282-
expect(
283-
output,
284-
contains('''
275+
testWithoutContext(
276+
'correctly outputs colored exceptions when supported',
277+
() async {
278+
final BasicProjectThatThrows project = BasicProjectThatThrows();
279+
final String output = await getExceptionOutput(project, noDebug: false, ansiColors: true);
280+
281+
// Frames in the stack trace that are the users own code will be unformatted, but
282+
// frames from the framework are faint (starting with `\x1B[2m`).
283+
284+
expect(
285+
output,
286+
contains('''
285287
════════ Exception caught by widgets library ═══════════════════════════════════
286288
The following _Exception was thrown building App(dirty):
287289
Exception: c
@@ -298,8 +300,10 @@ When the exception was thrown, this was the stack:
298300
^ source: package:flutter/src/widgets/framework.dart
299301
\x1B[2m#3 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:1:1)\x1B[0m
300302
^ source: package:flutter/src/widgets/framework.dart'''),
301-
);
302-
});
303+
);
304+
},
305+
skip: true, // DAP URI parsing bug, https://github.com/dart-lang/sdk/issues/60797
306+
);
303307

304308
testWithoutContext('correctly outputs exceptions in noDebug mode', () async {
305309
final BasicProjectThatThrows project = BasicProjectThatThrows();

0 commit comments

Comments
 (0)
0