8000 [CP-beta]Move `backfill: "false"` out of properties, make it a boolea… · flutter/flutter@3d03881 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3d03881

Browse files
[CP-beta]Move backfill: "false" out of properties, make it a boolean. (#167831)
This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request) Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request. ### Issue Link: What is the link to the issue this cherry-pick is addressing? #167755 ### Changelog Description: Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples N/A (CI Infrastructure Only) ### Impact Description: What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch) Allows removing technical debt from Cocoon. ### Workaround: Is there a workaround for this issue? N/A ### Risk: What is the risk level of this cherry-pick? ### Test Coverage: Are you confident that your fix is well-tested by automated tests? ### Validation Steps: What are the steps to validate that this fix works? It is already live on the master channel.
1 parent 030e2a5 commit 3d03881

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.ci.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -585,6 +585,7 @@ targets:
585585
- name: Linux docs_publish
586586
recipe: flutter/docs
587587
presubmit: false
588+
backfill: false
588589
timeout: 60
589590
dimensions:
590591
os: "Linux"
@@ -603,7 +604,6 @@ targets:
603604
]
604605
tags: >
605606
["framework", "hostonly", "linux"]
606-
backfill: "false"
607607
validation: docs
608608
validation_name: Docs
609609
firebase_project: main-docs-flutter-prod

engine/src/flutter/.ci.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -263,9 +263,9 @@ targets:
263263
recipe: engine_v2/engine_v2
264264
bringup: true
265265
timeout: 120
266+
backfill: false
266267
properties:
267268
release_build: "false"
268-
backfill: "false"
269269
config_name: linux_host_engine_ddm
270270
dependencies: >-
271271
[
@@ -305,10 +305,10 @@ targets:
305305
recipe: engine_v2/engine_v2
306306
bringup: true
307307
timeout: 120
308+
backfill: false
308309
properties:
309310
config_name: linux_android_aot_engine_ddm
310311
release_build: "false"
311-
backfill: "false"
312312
# Do not remove(https://github.com/flutter/flutter/issues/144644)
313313
# Scheduler will fail to get the platform
314314
drone_dimensions:
@@ -343,9 +343,9 @@ targets:
343343
recipe: engine_v2/engine_v2
344344
bringup: true
345345
timeout: 120
346+
backfill: false
346347
properties:
347348
release_build: "false"
348-
backfill: "false"
349349
config_name: linux_android_debug_engine_ddm
350350
# Do not remove(https://github.com/flutter/flutter/issues/144644)
351351
# Scheduler will fail to get the platform

0 commit comments

Comments
 (0)
0