8000 Merge pull request #112 from danielgtaylor/pr/readme-contribution · fixpoint/python-betterproto@b265133 · GitHub
[go: up one dir, main page]

Skip to content

Commit b265133

Browse files
Merge pull request danielgtaylor#112 from danielgtaylor/pr/readme-contribution
Updated readme with contribution section. More help welcome 😃
2 parents 8bcb67b + 5a591ef commit b265133

File tree

2 files changed

+27
-3
lines changed

2 files changed

+27
-3
lines changed

CONTRIBUTING.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
# Contributing
2+
3+
There's lots to do, and we're working hard, so any help is welcome!
4+
5+
- :speech_balloon: Join us on [Slack](https://join.slack.com/t/betterproto/shared_invite/zt-f0n0uolx-iN8gBNrkPxtKHTLpG3o1OQ)!
6+
7+
What can you do?
8+
9+
- :+1: Vote on [issues](https://github.com/danielgtaylor/python-betterproto/issues).
10+
- :speech_balloon: Give feedback on [Pull Requests](https://github.com/danielgtaylor/python-betterproto/pulls) and [Issues](https://github.com/danielgtaylor/python-betterproto/issues):
11+
- Suggestions
12+
- Express approval
13+
- Raise concerns
14+
- :small_red_triangle: Create an issue:
15+
- File a bug (please check its not a duplicate)
16+
- Propose an enhancement
17+
- :white_check_mark: Create a PR:
18+
- [Creating a failing test-case](https://github.com/danielgtaylor/python-betterproto/blob/master/betterproto/tests/README.md) to make bug-fixing easier
19+
- Fix any of the open issues
20+
- [Good first issues](https://github.com/danielgtaylor/python-betterproto/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22)
21+
- [Issues with tests](https://github.com/danielgtaylor/python-betterproto/issues?q=is%3Aissue+is%3Aopen+label%3A%22has+test%22)
22+
- New bugfix or idea
23+
- If you'd like to discuss your idea first, join us on Slack!

README.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -304,7 +304,8 @@ datetime.datetime(2019, 1, 1, 11, 59, 58, 800000, tzinfo=datetime.timezone.utc)
304304

305305
## Development
306306

307-
Join us on [Slack](https://join.slack.com/t/betterproto/shared_invite/zt-f0n0uolx-iN8gBNrkPxtKHTLpG3o1OQ)!
307+
- _Join us on [Slack](https://join.slack.com/t/betterproto/shared_invite/zt-f0n0uolx-iN8gBNrkPxtKHTLpG3o1OQ)!_
308+
- _See how you can help → [Contributing](CONTRIBUTING.md)_
308309

309310
### Requirements
310311

@@ -434,10 +435,10 @@ protoc \
434435
- [x] Enum strings
435436
- [x] Well known types support (timestamp, duration, wrappers)
436437
- [x] Support different casing (orig vs. camel vs. others?)
437-
- [ ] Async service stubs
438+
- [x] Async service stubs
438439
- [x] Unary-unary
439440
- [x] Server streaming response
440-
- [ ] Client streaming request
441+
- [x] Client streaming request
441442
- [x] Renaming messages and fields to conform to Python name standards
442443
- [x] Renaming clashes with language keywords
443444
- [x] Python package

0 commit comments

Comments
 (0)
0