Add horcrux completion#9922
Merged
faho merged 3 commits intofish-shell:masterfrom Aug 9, 2023
EmilyGraceSeville7cf:feature/horcrux-completion
Merged
Add horcrux completion#9922faho merged 3 commits intofish-shell:masterfrom EmilyGraceSeville7cf:feature/horcrux-completion
faho merged 3 commits intofish-shell:masterfrom
EmilyGraceSeville7cf:feature/horcrux-completion
Conversation
Member
|
Merged, thanks! |
faho
pushed a commit
that referenced
this pull request
Oct 6, 2023
* feat(completions): horcrux * feat(changelog): mention completion * fix(completion): condition for -n (cherry picked from commit f9d21cc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
https://github.com/jesseduffield/horcrux
Fixes issue #
TODOs:
Notes
For some reason, options are passed before
splitsubcommand. As @faho responded in Gitter it's not the way Fish completions should work.