Fix integer overflow in string repeat#9900
Merged
faho merged 1 commit intofish-shell:masterfrom Jul 17, 2023
Merged
Conversation
faho
reviewed
Jul 17, 2023
Member
|
Would you like this merged before #9854, which would mean that would need to be rebased again? |
Contributor
Author
Yes that's fine, this isn't too bad to fix in a rebase |
We could end up overflowing if we print out something that's a multiple of the chunk size, which would then finish printing in the chunk-printing, but not break out early.
9a6e00b to
cb0c6fe
Compare
Member
|
Alright, merged, thanks! Might be worth it to hold off on rebasing #9854 while there's review going on, not sure github won't mess up the comments otherwise. |
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could end up overflowing if we print out something that's a multiple of the
chunk size, which would then finish printing in the chunk-printing, but not
break out early.