8000 yash: add completion by EmilyGraceSeville7cf · Pull Request #9391 · fish-shell/fish-shell · GitHub
[go: up one dir, main page]
Skip to content

yash: add completion#9391

Closed
EmilyGraceSeville7cf wants to merge 2 commits intomasterfrom
unknown repository
Closed

yash: add completion#9391
EmilyGraceSeville7cf wants to merge 2 commits intomasterfrom
unknown repository

Conversation

@EmilyGraceSeville7cf
Copy link
Contributor
@EmilyGraceSeville7cf EmilyGraceSeville7cf commented Nov 27, 2022

Description

Add yash completion.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho
8000 Copy link
Member
faho commented Nov 27, 2022 •
edited
Loading

Please, in future, group these very simple completions for very simple (argument-wise) commands together in a single PR to make it easier to review and merge.

Opening a PR every hour isn't very helpful because it requires us to open the PR, look at it and press the "merge" button every hour. If these were grouped it would be easier on us and you. Just make a branch "new-simple-completions", save up until you have a few of these and then open a PR.

@faho faho added this to the fish 3.6.0 milestone Dec 22, 2022
@faho
Copy link
Member
faho commented Dec 24, 2022

Merged via cherry-pick as f15e5ce.

@faho faho closed this Dec 24, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

completions enhancement

Projects

None yet

Milestone

fish 3.6.0

Development

Successfully merging this pull request may close these issues.

2 participants

@EmilyGraceSeville7cf @faho
0