Merged
Conversation
krobelus
reviewed
Jul 23, 2022
| complete -c zig -n "__fish_seen_subcommand_from $zig_build_generic_commands" -l verbose-llvm-ir -d "Enable compiler debug output for LLVM IR" | ||
| complete -c zig -n "__fish_seen_subcommand_from $zig_build_generic_commands" -l verbose-cimport -d "Enable compiler debug output for C imports" | ||
| complete -c zig -n "__fish_seen_subcommand_from $zig_build_generic_commands" -l verbose-llvm-cpu-features -d "Enable compiler debug output for LLVM CPU features" | ||
| complete -x -c zig -n "__fish_seen_subcommand_from $zig_build_generic_commands" -l debug-log -d "Enable printing debug/info log messages for scope" |
Contributor
There was a problem hiding this comment.
unfortunately this disables file completions, can we add something to the -n parameter so it doesn't?
I believe that clang completions only trigger if the current token starts with -, so maybe that?
Looks really great otherwise!
Contributor
Author
There was a problem hiding this comment.
The argument of --debug-log is not files (https://github.com/ziglang/zig/blob/370793a36b3de34ead8456553a2aa2c56f0d3de8/src/main.zig#L497). So, this is as expected.
I'll fix the file completion for zig cc and zig c++ to be enabled.
Change to enable filename completion on `zig cc` and `zig c++`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add completions for the reference implementation of the the Zig programming language.
Fixes issue #
TODOs: