8000 Update single layer stripping by YmirKhang · Pull Request #8918 · fish-shell/fish-shell · GitHub
[go: up one dir, main page]

Skip to content

Update single layer stripping#8918

Merged
faho merged 2 commits intofish-shell:masterfrom
YmirKhang:single-quote-strip-fix
Apr 28, 2022
Merged

Update single layer stripping#8918
faho merged 2 commits intofish-shell:masterfrom
YmirKhang:single-quote-strip-fix

Conversation

@YmirKhang
Copy link
Contributor
@YmirKhang YmirKhang commented Apr 27, 2022

Description

Fixed words and phrases being stripped of multiple single quotes. As per the comment of the function states, only one layer of single quotas need to be stripped. The strip method in python actually removes as many trailing and leading characters as it can.

Fixes issue #8917

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho added the bug Something that's not working as intended label Apr 28, 2022
@faho faho added this to the fish 3.5.0 milestone Apr 28, 2022
@faho faho merged commit 908da62 into fish-shell:master Apr 28, 2022
@faho
Copy link
Member
faho commented Apr 28, 2022

Merged, thanks!

@YmirKhang
Copy link
Contributor Author

Merged, thanks!

You're welcome

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something that's not working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0