8000 GitHub · Where software is built
[go: up one dir, main page]

Skip to content

Pass all of $argv to pk-command-not-found #8579

@septatrix

Description

@septatrix

When encountering an unknown command fish defers to different handlers.
In #365 it was changed that these handlers receive all of $argv though that was quickly reverted as some handlers are unable to cope with that (3559f20 and 7a1fc02).

Some handlers like PackageKit however are able to deal with them and properly pass them along when executing the fixed commands.

~ $ grep SingleMatch /etc/PackageKit/CommandNotFound.conf  # this is just for demonstration
SingleMatch=ask
~ $ /usr/libexec/pk-command-not-found mna --version
fish: mna: command not found...
Run similar command: man [Y/n] y


man 2.9.4
~ $ mna --version
fish: mna: command not found...
Run similar command: man [Y/n] y


What manual page do you want?
For example, try 'man man'.
~ [127]$ function fish_command_not_found
             /usr/libexec/pk-command-not-found $argv
         end
~ $ mna --version
fish: mna: command not found...
Run similar command: man [Y/n] y


man 2.9.4

After looking at the current implementation I overwrote the function and everything still worked flawlessly.
I think it would be best to change this for the PackageKit handler.


Version: 3.3.1

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0