8000 Add completions for `wslpath` by KiruyaMomochi · Pull Request #8364 · fish-shell/fish-shell · GitHub
[go: up one dir, main page]

Skip to content

Add completions for wslpath#8364

Merged
faho merged 2 commits intofish-shell:masterfrom
KiruyaMomochi:patch-1
Oct 22, 2021
Merged

Add completions for wslpath#8364
faho merged 2 commits intofish-shell:masterfrom
KiruyaMomochi:patch-1

Conversation

@KiruyaMomochi
Copy link
Contributor

Description

This PR adds completion for wslpath to fish.

wslpath is a command line tool to do WSL<->Windows path conversions.
Details can be found at WSL Release Notes, build 17046

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@faho faho merged commit be9b882 into fish-shell:master Oct 22, 2021
@faho
Copy link
Member
faho commented Oct 22, 2021

Merged, thanks!

@KiruyaMomochi
Copy link
Contributor Author
KiruyaMomochi commented Oct 22, 2021

Sorry but I seem have put wslpath's change log entry to a incorrect place.
It should be in fish 3.4.0 (released ???) ​instead of fish 2.7b1 (released October 31, 2017).

Should I create another Pull Request?
Again, I apologize for the inconvenience.

@faho
Copy link
Member
faho commented Oct 22, 2021

No worries, I'll just do it.

@faho
Copy link
Member
faho commented Oct 22, 2021

c747520

@KiruyaMomochi
Copy link
Contributor Author

Thanks!

@zanchey zanchey added this to the fish 3.4.0 milestone Dec 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0