fish_pager_color_*background variables don't support -b option #8053
Description
Eg.
set fish_pager_color_background --background=red works, while
set fish_pager_color_background -b red does not, but probably should.
While you're at it, please add some clarification to the docs:
-
The relevant section "Syntax highlighting variables" states:
The --bold or -b switches accepted by set_color are also accepted.
This is misleading, because for
set_color,-bis equivalent to--background, while--boldis shortened to-o. Additionally, all other options (bold, italic, underline, reverse, dim) also seem to be supported, both as long and short options. -
It's a little bit confusing that the variables ending in
_backgroundhave to be set with the additional--backgroundoption. I know this is technically easier to do, and I don't even know if it would be less confusing if we could omit that. Current state seems to be:
a) every_backgroundvariable only suppports the--backgroundoption, nothing else.
b) every other (foreground) variable supports every styling option fromset_color(i.e. bold, underline, italic, reverse, dim), but not--background.
Question: how does fish internally color these parts? Are foreground and background color handled differently, or is there a call to set_color somewhere? Because I don't know why we shouldn't be able to also color the background for fish's syntax highlighting. I noticed that the foreground colors still support the reverse option, but I'm not sure if this is handled by fish or my terminal.
Tested with both version 3.2.2 and latest build 3.2.2-388-g695027234 from git on Arch Linux.