Make default vi mode prompt a bit nicer to look at#7880
Merged
faho merged 1 commit intofish-shell:masterfrom Mar 31, 2021
Merged
Make default vi mode prompt a bit nicer to look at#7880faho merged 1 commit intofish-shell:masterfrom
faho merged 1 commit intofish-shell:masterfrom
Conversation
The default vi mode prompt is kind of ugly, mostly because we include this `[I]` with a super bright green background and white text, which is particularly grating because most prompts don't actually have a background. So we get a ton of people asking "How do I remove this [I]" when they could really benefit from having the mode shown. There's a few ways to make this look nicer, the simplest is to just keep the same colors but use them as foreground instead of background colors, which looks much more understated. The mode prompt is important, but not more than the actual contents of the commandline, so it shouldn't have ALARMING colors.
Member
|
Nice, looks much better! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The default vi mode prompt is kind of ugly, mostly because we include
this
[I]with a super bright green background and white text,which is particularly grating because most prompts don't actually have
a background.
So we get a ton of people asking "How do I remove this [I]" when they
could really benefit from having the mode shown.
There's a few ways to make this look nicer, the simplest is to just
keep the same colors but use them as foreground instead of background
colors, which looks much more understated.
The mode prompt is important, but not more than the actual contents of
the commandline, so it shouldn't have ALARMING colors.
Before:
After:
TODOs: