Don't chomp foo= when completing foo=br#7398
Merged
krobelus merged 1 commit intofish-shell:masterfrom Oct 14, 2020
Merged
Conversation
`complete_param_expand` knows how to handle cases like `foo=br` so we don't need to bother sending just the `br` part. Furthermore, sending just `br` is incorrect because we will end up replacing the entirety of `foo=br` with the result of the completion. That is, `foo=br` will be replaced with `bar` instead of being completed to `foo=bar`.
Contributor
|
Right, a fuzzy completion will set COMPLETE_REPLACES_TOKEN, so the entire token is replaced. |
Contributor
Author
|
No problem! If it's not too much to ask, could you label this PR as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
complete_param_expandknows how to handle cases likefoo=brso wedon't need to bother sending just the
brpart. Furthermore, sendingjust
bris incorrect because we will end up replacing the entirety offoo=brwith the result of the completion. That is,foo=brwill bereplaced with
barinstead of being completed tofoo=bar.Fixes a bug where the following
will be completed to just
instead of
This doesn't happen when the command is being invoked with
envlikeenv foo=/vr<TAB>. It also only occurs when the completion requires replacement. Sofoo=/vawill correctly be completed tofoo=/var/.TODOs: