8000 Add completions for some missing GLib's tools by sorairolake · Pull Request #7300 · fish-shell/fish-shell · GitHub
[go: up one dir, main page]
Skip to content

Add completions for some missing GLib's tools#7300

Merged
krobelus merged 5 commits intofish-shell:masterfrom
sorairolake:feature/glibCompletions
Sep 1, 2020
Merged

Add completions for some missing GLib's tools#7300
krobelus merged 5 commits intofish-shell:masterfrom
sorairolake:feature/glibCompletions

Conversation

@sorairolake
Copy link
Contributor
@sorairolake sorairolake commented Aug 31, 2020 •
edited
Loading

Description

Completions of GLib's tools doesn't exist except gsettings, so add it.

Fixes issue #

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.rst

@krobelus krobelus added this to the fish 3.2.0 milestone Sep 1, 2020
krobelus
krobelus reviewed Sep 1, 2020
View reviewed changes
Copy link
Contributor
@krobelus krobelus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@krobelus krobelus merged commit 244feee into fish-shell:master Sep 1, 2020
@krobelus
Copy link
Contributor
krobelus commented Sep 1, 2020

Merged with my suggestions, I hope I didn't mess up anything ;)

@sorairolake sorairolake deleted the feature/glibCompletions branch September 8, 2020 01:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@krobelus krobelus krobelus left review comments

Assignees

No one assigned

Labels

completions enhancement

Projects

None yet

Milestone

fish 3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sorairolake @krobelus
0