Make fish_key_reader exit normally#6964
Merged
zanchey merged 1 commit intofish-shell:masterfrom May 5, 2020
Merged
Conversation
fish_key_reader exit normally
zanchey
reviewed
May 3, 2020
8000
src/fish_key_reader.cpp
Outdated
| case 'v': { | ||
| std::fwprintf(stdout, L"%s\n", get_fish_version()); | ||
| return false; | ||
| std::fwprintf(stderr, _(L"%ls, version %s\n"), program_name, get_fish_version()); |
Member
There was a problem hiding this comment.
Probably this should go to stdout as before.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review. I copied that snippet from fish_indent.cpp. Should it be changed to stdout as well?
Contributor
There was a problem hiding this comment.
yes the version flags should all print to stdout
Contributor
Author
There was a problem hiding this comment.
They print to stdout now.
Member
|
Tha 8000 nks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
--helpand--versionoptions were returning status 1 instead of 0.This aligns the behavior of
fish,fish_indent, andfish_key_reader.Also the file descriptor passed to
print_helpwas wrong.