Fix 256 color detection on xterm-like#6701
Merged
faho merged 1 commit intofish-shell:masterfrom Mar 3, 2020
Shaac:color-xterm
Merged
Fix 256 color detection on xterm-like#6701faho merged 1 commit intofish-shell:masterfrom Shaac:color-xterm
faho merged 1 commit intofish-shell:masterfrom
Shaac:color-xterm
Conversation
bbc3fec introduced a regression where support for 256 color was not detected on xterm-like terminals that did not define the TERM_PROGRAM env variable. Almost no terminal on linux define this variable.
Member
|
Thanks, nice catch. Merged to master, cherry-picked to 3.1.1 as e0645c9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bbc3fec introduced a regression where support for 256 color was not
detected on xterm-like terminals that did not define the TERM_PROGRAM
env variable. Almost no terminal on linux define this variable.
Description
The upgrade from fish 3.0 to 3.1 broke the color on my terminal (kitty). Its
TERMenvironment variable isxterm-kitty, and it does not define aTERM_PROGRAMenv variable (neither do xterm, or urxvt). I changed the logic of checking for Terminal.app back to what it was before bbc3fec and fixed the problem.TODOs: