8000 Add completions/sfdx.fish by matoruru · Pull Request #6149 · fish-shell/fish-shell · GitHub
[go: up one dir, main page]
Skip to content

Add completions/sfdx.fish#6149

Merged
faho merged 4 commits intofish-shell:masterfrom
matoruru:add-sfdx-completion
Oct 7, 2019
Merged

Add completions/sfdx.fish#6149
faho merged 4 commits intofish-shell:masterfrom
matoruru:add-sfdx-completion

Conversation

@matoruru
Copy link
Contributor
@matoruru matoruru commented Sep 30, 2019 •
edited
Loading

Description

Hello maintainers,

This is a completion to make useful sfdx(Single command-line interface for Force.com and all Salesforce DX features) command. sfdx command has so many many subcommands so I think it often makes us confused. I hope this feature helps to solve this problem.

It makes many salesforce developers and fish-shell users happier.

Thank you.

TODOs:

  • Changes to fish usage are reflected in user documentation/manpages.
  • Tests have been added for regressions fixed
  • User-visible changes noted in CHANGELOG.md

faho
faho requested changes Oct 6, 2019
View reviewed changes
@faho faho added this to the fish 3.1.0 milestone Oct 6, 2019
@matoruru
8000 Copy link
Contributor Author
matoruru commented Oct 6, 2019

Is it better to squash these 4 commits to one?

@faho
Copy link
Member
faho commented Oct 6, 2019

Is it better to squash these 4 commits to one?

We can do that once we merge.

In general I recommend leaving commits as they are while a PR is being reviewed, to avoid confusing the reviewer.

Once you're done, in fish we'll merge it and we can take care of squashing or rebasing - github even has buttons for a squash or a simple rebase merge.

@matoruru
Copy link
Contributor Author
matoruru commented Oct 6, 2019

We can do that once we merge.

Once you're done, in fish we'll merge it and we can take care of squashing or rebasing - github even has buttons for a squash or a simple rebase merge.

I didn't know that features on GitHub, and I see, then I leave it to you.

In general I recommend leaving commits as they are while a PR is being reviewed, to avoid confusing the reviewer.

Yes now I know what you said. Actually this is the first time to get change requests for me.
I'm sorry it's my mistake, I'll do that next time.

@matoruru
Copy link
Contributor Author
matoruru commented Oct 6, 2019

Thank you to teach me a lot kindly and support.

@faho faho merged commit 422441e into fish-shell:master Oct 7, 2019
@faho
Copy link
Member
faho commented Oct 7, 2019

Merged, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2020
@matoruru matoruru deleted the add-sfdx-completion branch October 6, 2020 06:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@faho faho faho requested changes

Assignees

No one assigned

Labels

completions enhancement

Projects

None yet

Milestone

fish 3.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@matoruru @faho
0