8000 Ripgrep completions are in conflict with completions provided by ripgrep itself · Issue #5822 · fish-shell/fish-shell · GitHub
[go: up one dir, main page]

Skip to content

Ripgrep completions are in conflict with completions provided by ripgrep itself #5822

@ronjouch

Description

@ronjouch

Since 5989a92 by @mqudsi, building the fish-git AUR package succeeds, but installation fails with:

error: failed to commit transaction (conflicting files)
fish-git: /usr/share/fish/completions/rg.fish exists in filesystem (owned by ripgrep)

I'm filing this issue but I'm uncertain who's "right" and who should be providing these completions:

  • I'm guessing it should be ripgrep...
  • ... but fish providing the completions means users with improper ripgrep installations (for example users who just dropped the binary in $PATH) will still get completions.
  • If fish keeps shipping completions, a simple "fix" for the AUR package would be to add to package() a little rm "$pkgdir/usr/share/fish/completions/rg.fish"

Anyway, you already provide tons of completions, so I guess you already know what's the right thing to do here. So, feedback welcome, I'll pass it on to AUR packagers.

As usual, thanks a million for fish!

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0