Replace read -i with read -s #4490
Description
read's support for --silent came late in the game and -s was already being used for --shell.
How does everyone feel about making -s for --silent/--secure similar to bash and others, and changing --shell to something else? It seems the only place read -s is currently used in our code is just in funced.fish.