Fix status code when bad command name is entered#3616
Merged
ridiculousfish merged 1 commit intofish-shell:masterfrom Dec 3, 2016
Merged
Fix status code when bad command name is entered#3616ridiculousfish merged 1 commit intofish-shell:masterfrom
ridiculousfish merged 1 commit intofish-shell:masterfrom
Conversation
This commit fixes a bug which causes that
fish -c ')'; echo $status
("Illegal command name" error) returns 0. This is inconsistent with
e.g. when trying to run non-existent command:
fish -c 'invalid-command'; echo $status
("Unknown command" error) which correctly returns 127.
A new status code,
STATUS_ILLEGAL_CMD = 123
is introduced - which is returned whenever the 'Illegal command name *'
message is printed.
This commit also adds a test which checks if valid commands return 0,
while commands with illegal name return status code 123.
Fixes fish-shell#3606.
Member
|
Thanks for the great contribution. The tests look outstanding! I like the introduction of |
Member
|
Merged. Thank you!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit fixes a bug which causes that
("Illegal command name" error) returns 0. This is inconsistent with
e.g. when trying to run non-existent command:
("Unknown command" error) which correctly returns 127.
A new status code,
is introduced - which is returned whenever the 'Illegal command name *'
message is printed.
This commit also adds a test which checks if valid commands return 0,
while commands with illegal name return status code 123.
Fixes #3606.
TODOs:
STATUS_ILLEGAL_CMD=123should really be added, orSTATUS_UNKNOWN_COMMAND=127should be reused (as the issue reporter suggested)What do you think? Should
STATUS_UNKNOWN_COMMANDbe used instead? I don't have problems rewriting the commit to use it instead of new status code.And please check the test. I'm not very experienced with C++ .