an invalid flag to function is handled wrong#3574
Closed
krader1961 wants to merge 1 commit intofish-shell:masterfrom
krader1961:function-invalid-flag
Closed
an invalid flag to function is handled wrong#3574krader1961 wants to merge 1 commit intofish-shell:masterfrom krader1961:function-invalid-flag
function is handled wrong#3574krader1961 wants to merge 1 commit intofish-shell:masterfrom
krader1961:function-invalid-flag
Conversation
Specifically, an invalid flag keeps the function from being defined but does not emit an error message. Fixes #2827
Contributor
Author
|
Closed with merge of commit 320cb68. |
Contributor
|
There is one issue, currently it is impossible to define function with name |
Contributor
Author
|
@hauleth: The solution is to use an abbreviation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically, an invalid flag keeps the function from being defined but
does not emit an error message.
Fixes #2827