8000 Kill etc/config.fish by faho · Pull Request #2799 · fish-shell/fish-shell · GitHub
[go: up one dir, main page]
Skip to content

Kill etc/config.fish#2799

Closed
faho wants to merge 5 commits intofish-shell:masterfrom
faho:etc
Closed

Kill etc/config.fish#2799
faho wants to merge 5 commits intofish-shell:masterfrom
faho:etc

Conversation

@faho
Copy link
Member
@faho faho commented Mar 6, 2016

(Sorry, I know this is a bit late)

Like @amluto asked for in #2498, remove etc/config.fish by appending the code to share/config.fish.

This improves life for packagers as there's one less file in etc (thought of as user/admin territory in recent years). Also there's one less file for us to worry about.

It might be nice to nix these two remaining things entirely but I'm not too sure about that.

While I was at it, I've also stringified it, which is why I'd like a quick check from someone else.

@krader1961
Copy link
Contributor
krader1961 commented Mar 6, 2016

lgtm

@zanchey
Copy link
Member
zanchey commented Mar 7, 2016

Perhaps we should leave a skeleton file in etc/config.fish - something along the lines of:

# config.fish
# Put system-wide fish configuration entries here
# or in .fish files in conf.d/

# This file is run by all fish instances.
# To include configuration only for login shells, use
# if status --is-login
#    ...
# end
# To include configuration only for interactive shells, use
# if status --is-interactiv
#   ...
# end

@faho
Copy link
Member Author
faho commented Mar 7, 2016

@zanchey: If I understand correctly, packagers would prefer not to have files in /etc at all (for "stateless systems" and to have one less file to backup if it changed), so that would kind of defeat the point.

Though we should probably still create the directory.

@amluto: Did I get that right?

@amluto
Copy link
Contributor
amluto commented Mar 8, 2016

A bunch of the actual empty-/etc stuff is being done in the OSTree project,
and I don't know too much about the fine details. But I don't have a
strong preference between omitting the file and leaving in a placeholder.
As long as fish is fully functional without anything in /etc, everyone wins
:)

On Mon, Mar 7, 2016 at 4:13 AM, Fabian Homborg notifications@github.com
wrote:

@zanchey https://github.com/zanchey: If I understand correctly,
packagers would prefer not to have files in /etc at all (for "stateless
systems" and to have one less file to backup if it changed), so that would
kind of defeat the point.

Though we should probably still create the directory.

@amluto https://github.com/amluto: Did I get that right?

—
Reply to this email directly or view it on GitHub
#2799 (comment)
.

@faho
Add a skeleton etc/config.fish
03a1b34 
This contains a bit of information on how fish's configuration works for
the admin, but fish still won't _require_ anything from /etc as the file
can be safely removed.
@zanchey
Copy link
Member
zanchey commented Mar 9, 2016

r+ - go ahead and merge.

As a packager I'm not fussed by no-op files, but as a systems admin I'd like to have a template or example available.

@zanchey zanchey added this to the 2.3.0 milestone Mar 9, 2016
@faho
Copy link
Member Author
faho commented Mar 9, 2016

Merged as 6288f89. Thanks!

@faho faho closed this Mar 9, 2016
@faho faho deleted the etc branch March 9, 2016 12:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cleanup packaging

Projects

None yet

Milestone

fish 2.3.0

Development

Successfully merging this pull request may close these issues.

4 participants

@faho @krader1961 @zanchey @amluto
0