Handle environment variables with = signs correctly#2403
Closed
crmne wants to merge 1 commit intofish-shell:masterfrom
Closed
Handle environment variables with = signs correctly#2403crmne wants to merge 1 commit intofish-shell:masterfrom
crmne wants to merge 1 commit intofish-shell:masterfrom
Conversation
Member
|
This sounds okay, but I'd like a comment codifying this, so someone touching it (and I'll probably touch every single |
Member
|
Hi, I've now pushed a slightly different solution using our new cool Still thanks for your contribution! |
Contributor
|
There is an issue with this fix, the \n is interpreted as "\n" instead of a line return. diff --git a/share/functions/export.fish b/share/functions/export.fish
index 7c6248e..5ffd27d 100644
--- a/share/functions/export.fish
+++ b/share/functions/export.fish
@@ -5,7 +5,7 @@ function export --description 'Set global variable. Alias for set -gx, made for
end
for arg in $argv
# Only split on the first =
- set -l v (echo $arg | string replace "=" "\n")
+ set -l v (echo $arg | string replace "=" \n)
set -l c (count $v)
switch $c
case 1 |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scenario:
I need to run this line:
but the current implementation of the export function doesn't export anything, since the
trcommand would split the string at all the occurrences of the equal sign and end up having no case in the switch statement.Solution
By using
sedwe ensure that the string gets split at only the first occurrence of the equal sign, emulating more carefully bash's behavior.