[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooling] The genkit init spinner doesn't spin when installing npm packages #531

Closed
mjchristy opened this issue Jul 3, 2024 · 1 comment · Fixed by #683
Closed

[Tooling] The genkit init spinner doesn't spin when installing npm packages #531

mjchristy opened this issue Jul 3, 2024 · 1 comment · Fixed by #683
Assignees
@cabljac
Labels
bug Something isn't working tooling

Comments

@mjchristy
Copy link

Describe the bug
The npm installer icon spinner doesn't spin when running genkit init

To Reproduce
Steps to reproduce the behavior:

  1. Run genkit init

Expected behavior
It should spin to show that it is working

Screenshots
installing npm
@mjchristy mjchristy added bug Something isn't working tooling labels Jul 3, 2024
@i14h i14h added this to the 0.5.5 milestone Jul 3, 2024
@chrisraygill chrisraygill removed this from the 0.5.5 milestone Jul 18, 2024
@cabljac cabljac self-assigned this Jul 24, 2024
@cabljac
Copy link
Collaborator
cabljac commented Jul 25, 2024

https://github.com/sindresorhus/ora#why-does-the-spinner-freeze

The problem here is that js is single-threaded and the sync processes are stopping the spinner from advancing.

Investigating to see how we can resolve this

@cabljac cabljac mentioned this issue Jul 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cabljac cabljac

Labels
bug Something isn't working tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unblock spinner on init firebase/genkit
4 participants
@i14h @mjchristy @chrisraygill @cabljac