10BC0 feat(vertexai): Live API breaking changes by cynthiajoan · Pull Request #17299 · firebase/flutterfire · GitHub
[go: up one dir, main page]
Skip to content

feat(vertexai): Live API breaking changes #17299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 24, 2025
Merged

feat(vertexai): Live API breaking changes #17299

merged 10 commits into from
Apr 24, 2025

Conversation

cynthiajoan
Copy link
Collaborator

Description

  • Remove the enum for Voices and use voice name string instead
  • Wrap LiveServerMessage into LiveServerResponse for future feature extendable.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@cynthiajoan cynthiajoan merged commit 69cd2a6 into main Apr 24, 2025
25 of 29 checks passed
@cynthiajoan cynthiajoan deleted the vertexai/api_review_update branch April 24, 2025 18:39
@firebase firebase locked and limited conversation to collaborators Jul 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lyokone Lyokone Lyokone approved these changes

@natebosch natebosch natebosch approved these changes

@russellwheatley russellwheatley Awaiting requested review from russellwheatley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cynthiajoan @Lyokone @natebosch
0