From 3882a1a4d79fdfe68e7e6244fa2a1d77971ba780 Mon Sep 17 00:00:00 2001 From: Brian Li Date: Thu, 7 Nov 2024 16:21:12 -0500 Subject: [PATCH 1/2] fix error message --- src/emulator/tasksEmulator.ts | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/emulator/tasksEmulator.ts b/src/emulator/tasksEmulator.ts index 84ba5d61c31..f30af5b34e8 100644 --- a/src/emulator/tasksEmulator.ts +++ b/src/emulator/tasksEmulator.ts @@ -203,7 +203,11 @@ export class TasksEmulator implements EmulatorInstance { const locationId = req.params.location_id; const queueName = req.params.queue_name; if (!this.validateQueueId(queueName)) { - res.status(400).send("Invalid Queue ID"); + res.status(400).json({ + error: + "Queue ID must start with a letter followed by up to 62 letters, numbers, " + + "hyphens, or underscores and must end with a letter or a number", + }); return; } @@ -233,7 +237,7 @@ export class TasksEmulator implements EmulatorInstance { defaultUri: body.defaultUri, }; if (taskQueueConfig.rateLimits.maxConcurrentDispatches > 5000) { - res.status(400).send("cannot set maxConcurrentDispatches to a value over 5000"); + res.status(400).json({ error: "cannot set maxConcurrentDispatches to a value over 5000" }); return; } From aafb677417acf8cb5c6e0e61c2e0c69ff56c2b63 Mon Sep 17 00:00:00 2001 From: Brian Li Date: Thu, 7 Nov 2024 16:23:27 -0500 Subject: [PATCH 2/2] add changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8c34a1950c3..568ec39ce5a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1 +1,2 @@ - Bump the Firebase Data Connect local toolkit to v1.6.1, which fixes the `OrderDirection` enum with `Optional` types in Dart codegen and adds `@ExperimentalFirebaseDataConnect` annotations in Kotlin codegen to avoid compiler warnings. (#7912) +- Fix Task Queue Emulator error handling to display error message properly. (#7916)