[FDC] init confirms Cloud SQL provision #9095
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the firebase init dataconnect command by introducing an explicit user prompt to confirm the provisioning of a Cloud SQL instance and database. This change provides users with greater control over the setup process, allowing them to decide whether to provision Cloud SQL immediately or at a later time. It also adds a corresponding programmatic option for this behavior.
Highlights
- Cloud SQL Provisioning Confirmation: The
firebase init dataconnectcommand now includes a confirmation step, asking the user if they would like to provision their Cloud SQL instance and database immediately during the initialization process. This provides more control to the user. - New Configuration Option: A new boolean field,
shouldProvisionCSQL, has been added to theRequiredInfointerface to track the user's preference for Cloud SQL provisioning. This field is also exposed as aprovision_cloudsqloption in thefirebase inittool, allowing programmatic control over this behavior. - Testing Updates: The mock data in
src/init/features/dataconnect/index.spec.tshas been updated to reflect the addition of theshouldProvisionCSQLfield, ensuring tests cover the new functionality.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request introduces a confirmation prompt during firebase init dataconnect to ask the user whether they want to provision a Cloud SQL instance. This is a good addition for user experience. My review has identified a potential bug where the user's choice is not respected, an incomplete description for a new CLI flag, and a minor issue in the CHANGELOG. Please see the detailed comments for suggestions.
|
@joehan This one is a bit higher priority given Twitter feedback in the room. Please take a look~ |
Description
During
firebase init dataconnect, add a confirmation prompt before provisioning the Cloud SQL instance.In MCP tool
firebase_init, add option to opt-in provision Cloud SQL instance. By default, don't provision Cloud SQL.Scenarios Tested
Sample Commands