[FDC] Fix a small bug where firebase deploy didn't include GQL in folders
#8981
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug where firebase deploy was failing to correctly include GraphQL files located within subdirectories. The fix involves updating the file utility functions to recursively discover all .gql and .graphql files, ensuring that the deployment process correctly identifies and bundles all necessary GraphQL schema definitions, regardless of their folder depth.
Highlights
- Recursive GQL File Discovery: The
readGQLFilesfunction insrc/dataconnect/fileUtils.tshas been updated to utilize thegloblibrary. This change enables the function to recursively search for and include all.gqland.graphqlfiles located within the specified source directory and its subfolders, addressing the previous limitation where only top-level files were recognized. - Path Handling Refinement: The
toFilehelper function was adjusted to correctly process the full file paths returned by theglobutility. It now internally calculates the relative path from the source directory, ensuring proper file referencing within the system.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a bug where GraphQL files in subdirectories were not included during firebase deploy. The change correctly uses glob to find all .gql and .graphql files recursively. My feedback focuses on improving the usage of the glob library to make it more robust and secure, especially on different operating systems.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Tested connector with nested file.
firebase init dataconnectfirebase deployfirebase init dataconnectto download them