8000 Fix deploy with multiple target/site in firebase.json by chalosalvador · Pull Request #8314 · firebase/firebase-tools · GitHub
[go: up one dir, main page]
Skip to content

Fix deploy with multiple target/site in firebase.json #8314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 12, 2025
Merged

Fix deploy with multiple target/site in firebase.json #8314

merged 3 commits into from
Mar 12, 2025

Conversation

chalosalvador
Copy link
Member

Description

Fixes #8274 when using firebase.json with an array of sites/targets. Like the following:

{
  "hosting": [
    {
      "target": "static",
      "public": "public"
    },
    {
      "target": "prod",
      "source": ".",
      "ignore": [
        "firebase.json",
        "**/.*",
        "**/node_modules/**"
      ],
      "frameworksBackend": {
        "region": "europe-west1"
      }
    },
    {
      "target": "staging",
      "source": ".",
      "ignore": [
        "firebase.json",
        "**/.*",
        "**/node_modules/**"
      ],
      "frameworksBackend": {
        "region": "europe-west1"
      }
    }
  ]
}

Scenarios Tested

  • firebase.js deploy

  • firebase.js deploy --only hosting

  • firebase.js deploy --only hosting:static

  • firebase.js deploy --only hosting:prod

  • firebase.js deploy --only hosting:staging

  • firebase.js deploy --only hosting:prod,hosting:static

  • Also tested using site in firebase.json instead of target.

Sample Commands

@chalosalvador chalosalvador requested a review from leoortizz March 12, 2025 13:52
@leoortizz leoortizz mentioned this pull request Mar 12, 2025
Merged
leoortizz and others added 2 commits March 12, 2025 16:49
@leoortizz
refactor isDeployingWebFramework and tests (#8315)
a46cae5 
* refactor isDeployingWebFramework and tests

* comment

* comments

* comments

* use same tests for site and config
@chalosalvador
Changelog
16471d1
@leoortizz leoortizz enabled auto-merge (squash) March 12, 2025 15:52
@chalosalvador chalosalvador mentioned this pull request Mar 12, 2025
Closed
@leoortizz leoortizz merged commit bbc33ec into master Mar 12, 2025
54 of 55 checks passed
@leoortizz leoortizz deleted the chalosalvador/fix-8274-config-array branch March 12, 2025 16:11
@aalej aalej mentioned this pull request Mar 13, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoortizz leoortizz leoortizz approved these changes

Assignees
No one assigned
Labels
integration: web frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to deploy to firebase hosting for NextJS application, show 404 (not found) page
2 participants
@chalosalvador @leoortizz
0