8000 Fix FDC query template. by rosalyntan · Pull Request #7736 · firebase/firebase-tools · GitHub
[go: up one dir, main page]
Skip to content

Fix FDC query template. #7736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2024
Merged

Fix FDC query template. #7736

merged 1 commit into from
Sep 26, 2024

Conversation

rosalyntan
Copy link
Member
@rosalyntan rosalyntan commented Sep 26, 2024 •
edited
Loading

Description

Came across this issue before in previous bug bashes, where the default query template isn't able to run, but I wasn't sure if it was something weird with my state. I reproduced it while testing a different PR though so I do think it is an actual issue.

Scenarios Tested

Sample Commands

@rosalyntan rosalyntan requested a review from joehan September 26, 2024 05:18
joehan
joehan approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor
@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch - this looks correct against the schema now since there is no director field and it specifically says Movie -> MovieMetadata is 1-1

@joehan joehan merged commit 1603384 into master Sep 26, 2024
41 checks passed
@joehan joehan deleted the rosalyntan.conn branch September 26, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joehan joehan joehan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rosalyntan @joehan
0