8000 fix copied functions dist dir files for Next.js when source config ends with slash by leoortizz · Pull Request #7099 · firebase/firebase-tools · GitHub
[go: up one dir, main page]
Skip to content

fix copied functions dist dir files for Next.js when source config ends with slash #7099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2024
Merged

fix copied functions dist dir files for Next.js when source config ends with slash #7099

merged 2 commits into from
May 3, 2024

Conversation

leoortizz
Copy link
Member

Description

path.replace was breaking when source dir was e.g. web/, causing the final folder to be .hosting/functions.next instead of .hosting/functions/.next. Fixes #7062

Scenarios Tested

Sample Commands

@leoortizz leoortizz requested a review from jamesdaniels May 3, 2024 16:12
@leoortizz leoortizz self-assigned this May 3, 2024
@leoortizz leoortizz mentioned this pull request May 3, 2024
Closed
jamesdaniels
jamesdaniels approved these changes May 3, 2024
View reviewed changes
Copy link
Member
@jamesdaniels jamesdaniels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this still work in windows?

@leoortizz
Copy link
Member Author

Does this still work in windows?

yep, it also fixes the same issue on Windows. join FTW!

@leoortizz leoortizz merged commit dcc3d90 into master May 3, 2024
@leoortizz leoortizz deleted the leoortizz_nextjsPathFix branch May 3, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees

@leoortizz leoortizz

Labels
integration: web frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next.js SSR Deployment fails due to wrong firebase-tools creating wrong folder
2 participants
@leoortizz @jamesdaniels
0