8000 Fix hosting rewrite deployment bug for skipped functions by colerogers · Pull Request #6658 · firebase/firebase-tools · GitHub
[go: up one dir, main page]
Skip to content

Fix hosting rewrite deployment bug for skipped functions #6658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix hosting rewrite deployment bug for skipped functions #6658

merged 3 commits into from
Mar 15, 2024

Conversation

colerogers
Copy link
Contributor

Addresses #6636

@codecov-commenter
Copy link
codecov-commenter commented Jan 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.29%. Comparing base (82fe0e1) to head (9a86397).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6658   +/-   ##
=======================================
  Coverage   54.28%   54.29%           
=======================================
  Files         352      352           
  Lines       24541    24542    +1     
  Branches     5083     5083           
=======================================
+ Hits        13323    13324    +1     
  Misses      10006    10006           
  Partials     1212     1212

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colerogers colerogers requested review from inlined and taeold January 2, 2024 17:24
@chriswaterbury
Copy link

Any ETA on this? This bug a huge pain in our CI/CD pipeline

inlined
inlined approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member
@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cautious whether this will fix all problems, but there's no controversy with this change so I'm willing to LGTM and see. You've probably looked at this in more detail than me.

@colerogers colerogers enabled auto-merge (squash) March 15, 2024 18:40
@colerogers colerogers merged commit 9297af8 into master Mar 15, 2024
@aalej aalej mentioned this pull request Mar 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inlined inlined inlined approved these changes

@taeold taeold Awaiting requested review from taeold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colerogers @codecov-commenter @chriswaterbury @inlined
0