10BC0 Refactoring device heuristics collection to a helper class. by eldhosembabu · Pull Request #8432 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

Refactoring device heuristics collection to a helper class. #8432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 6, 2021
Merged

Refactoring device heuristics collection to a helper class. #8432

merged 8 commits into from
Aug 6, 2021

Conversation

eldhosembabu
Copy link
Contributor
@eldhosembabu eldhosembabu commented Jul 23, 2021 •
edited
Loading

Refactoring device heuristics to a helper class.

@google-cla google-cla bot added the cla: yes label Jul 23, 2021
@eldhosembabu eldhosembabu requested a review from ryanwilson August 3, 2021 17:23
@google-oss-bot
Copy link
google-oss-bot commented Aug 3, 2021 •
edited
Loading

Coverage Report

Affected SDKs

  • FirebaseDynamicLinks-iOS-FirebaseDynamicLinks.framework

    SDK overall coverage changed from 76.57% (216568f) to 76.67% (052e7aa) by +0.09%.

    Filename Base (216568f) Head (052e7aa) Diff
    FDLDeviceHeuristicsHelper.m ? 100.00% ?
    FIRDynamicLinkNetworking.m 81.32% 81.27% -0.05%

Test Logs

ryanwilson
ryanwilson approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member
@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: please fix the changelog otherwise LGTM

ryanwilson
ryanwilson requested changes Aug 3, 2021
View reviewed changes
Copy link
Member
@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the copyrights in the new files as well.

ryanwilson
ryanwilson reviewed Aug 5, 2021
View reviewed changes
@eldhosembabu eldhosembabu requested a review from ryanwilson August 5, 2021 21:57
@eldhosembabu eldhosembabu merged commit af230bd into master Aug 6, 2021
@eldhosembabu eldhosembabu deleted the refactor-dh-logic branch August 6, 2021 20:13
@firebase firebase locked and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

Assignees
No one assigned
Labels
api: dynamiclinks cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eldhosembabu @google-oss-bot @ryanwilson
0