8000 Bump Promises dependency by ncooke3 · Pull Request #8365 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

Bump Promises dependency #8365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 9, 2021
Merged

Bump Promises dependency #8365

merged 8 commits into from
Jul 9, 2021

Conversation

ncooke3
Copy link
Member
@ncooke3 ncooke3 commented Jul 9, 2021 •
edited
Loading

Plan is to:

  • merge this PR
  • wait for clean nightlies
  • then publish GDT & GUL minor releases

Fixes #8334

@google-cla google-cla bot added the cla: yes label Jul 9, 2021
ncooke3
ncooke3 commented Jul 9, 2021
View reviewed changes
@paulb777
Copy link
Member
paulb777 commented Jul 9, 2021

Test the podspec changes first, to avoid the need to prematurely tag the GoogleUtilities and GTM repos.

The podspecs should be updated.

Bumping the GoogleUtilities minimum dependency is fine, but not required since the firebase-ios-sdk SPM should still work with 7.4.x ....

@ncooke3 ncooke3 requested a review from paulb777 July 9, 2021 16:32
@ncooke3
Copy link
Member Author
ncooke3 commented Jul 9, 2021

@paulb777 So with the specs bumped and CI green, GDT and GULs are good to publish, correct?

@paulb777
Copy link
Member
paulb777 commented Jul 9, 2021

Let's wait for a clean nightly run before publishing GDT and GoogleUtilities.

This is good to merge after adding a CHANGELOG update for 8.4.0

@ncooke3 ncooke3 marked this pull request as ready for review July 9, 2021 18:42
@ncooke3 ncooke3 requested review from peterfriese and removed request for peterfriese July 9, 2021 18:42
@ncooke3 ncooke3 enabled auto-merge (squash) July 9, 2021 19:09
@ncooke3 ncooke3 merged commit 77a006f into master Jul 9, 2021
@ncooke3 ncooke3 deleted the nc-bump-promises branch July 9, 2021 19:09
@paulb777 paulb777 added this to the 8.4.0 - M100 milestone Jul 9, 2021
@firebase firebase locked and limited conversation to collaborators Aug 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
api: appcheck api: crashlytics api: installations cla: yes
Projects
None yet
Milestone
8.4.0 - M100
Development

Successfully merging this pull request may close these issues.

Upgrade Promise dependency before Xcode 13 is released
3 participants
@ncooke3 @paulb777 @google-oss-bot
0