E536 Messaging - no typedefs in public APIs by paulb777 · Pull Request #6278 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

Messaging - no typedefs in public APIs #6278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2020
Merged

Messaging - no typedefs in public APIs #6278

merged 2 commits into from
Aug 17, 2020

Conversation

paulb777
Copy link
Member
@paulb777 paulb777 commented Aug 14, 2020 •
edited
Loading

From

Screen Shot 2020-08-14 at 3 07 22 PM

to

Screen Shot 2020-08-14 at 3 30 59 PM

charlotteliang
charlotteliang approved these changes Aug 14, 2020
View reviewed changes
Copy link
Contributor
@charlotteliang charlotteliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably update my new API review to follow this format.

charlotteliang
charlotteliang requested changes Aug 14, 2020
View reviewed changes
FirebaseMessaging/Sources/Public/FIRMessaging.h Outdated
*/
- (void)retrieveFCMTokenForSenderID:(NSString *)senderID
completion:(FIRMessagingFCMTokenFetchCompletion)completion
completion:(void (^_Nonnull)(NSString *_Nullable FCMToken,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is nonnull by default?

@paulb777 paulb777 merged commit b84e42d into master Aug 17, 2020
@paulb777 paulb777 deleted the pb-msg-typedef branch August 17, 2020 17:05
@firebase firebase locked and limited conversation to collaborators Sep 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ryanwilson ryanwilson ryanwilson approved these changes

@charlotteliang charlotteliang charlotteliang approved these changes

Assignees

@ryanwilson ryanwilson

Labels
api: messaging cla: yes public-api-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@paulb777 @ryanwilson @charlotteliang @googlebot @google-oss-bot
0