The instanceID sync API is deprecated. Implement the async instanceID API #3993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Oct 3, 2019
| FIRLogInfo(kFIRLoggerRemoteConfig, @"I-RCN000022", @"Success to get iid : %@.", | ||
| instanceIDStrongSelf->_settings.configInstanceID); | ||
| } else { | ||
| FIRLogWarning(kFIRLoggerRemoteConfig, @"I-RCN000055", @"Error getting iid : %@.", |
There was a problem hiding this comment.
Is it possible for !error && !identity? If so, this will crash.
There was a problem hiding this comment.
yes it is..not sure where we would crash though..
There was a problem hiding this comment.
@dmandar Thank you for updating it!
Mostly LGTM, just one question in the comments.
| __weak RCNConfigFetch *instanceIDSelf = strongSelf; | ||
| [instanceID getIDWithHandler:^(NSString *_Nullable identity, NSError *_Nullable error) { | ||
| RCNConfigFetch *instanceIDStrongSelf = instanceIDSelf; | ||
| instanceIDStrongSelf->_settings.configInstanceID = identity; |
There was a problem hiding this comment.
Should _settings be modified from the _lockQueue? [instanceID getIDWithHandler:] is called on the main queue. I wonder if the code will be simpler if we call [instanceID getIDWithHandler:] first (before line 209) and move the code with dispatch_async(instanceIDHandlerSelf->_lockQueue inside the getIDWithHandler: handler?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.