8000 [AI] Remove deprecated totalBillableCharacters property by ncooke3 · Pull Request #15056 · firebase/firebase-ios-sdk · GitHub
[go: up one dir, main page]
Skip to content

[AI] Remove deprecated totalBillableCharacters property #15056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 2, 2025
Merged

[AI] Remove deprecated totalBillableCharacters property #15056

merged 3 commits into from
Jul 2, 2025

Conversation

ncooke3
Copy link
Member
@ncooke3 ncooke3 commented Jun 30, 2025 •
edited
Loading

This commit removes the deprecated totalBillableCharacters property from CountTokensResponse and all its references in tests. The changelog has also been updated to reflect this change.

Open Q's

  • Remove on other platforms as well?

@google-labs-jules
Remove deprecated totalBillableCharacters property
703d164 
This commit removes the deprecated `totalBillableCharacters` property from `CountTokensResponse` and all its references in tests. The changelog has also been updated to reflect this change.
@gemini-code-assist Gemini Code Assist
Copy link
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

ncooke3
ncooke3 commented Jun 30, 2025
View reviewed changes
ncooke3
ncooke3 commented Jun 30, 2025
View reviewed changes
ncooke3
ncooke3 commented Jun 30, 2025
View reviewed changes
@ncooke3 ncooke3 added this to the Firebase 12 - M167 milestone Jun 30, 2025
@ncooke3 ncooke3 marked this pull request as draft June 30, 2025 19:21
@ncooke3 ncooke3 requested a review from paulb777 June 30, 2025 19:21
@ncooke3
Copy link
Member Author
ncooke3 commented Jun 30, 2025 •
edited
Loading

will assign Andrew later this week

@ncooke3 ncooke3 mentioned this pull request Jun 30, 2025
Closed
@ncooke3 ncooke3 marked this pull request as ready for review July 1, 2025 19:05
@ncooke3 ncooke3 requested a review from andrewheard July 2, 2025 13:58
andrewheard
andrewheard approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor
@andrewheard andrewheard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM other than moving (not changing) the release note.

@ncooke3 ncooke3 merged commit 22573fb into main Jul 2, 2025
27 of 28 checks passed
@ncooke3 ncooke3 deleted the remove-totalBillableCharacters branch July 2, 2025 14:55
@github-actions github-actions bot mentioned this pull request Jul 16, 2025
Merged
@firebase firebase locked and limited conversation to collaborators Aug 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@andrewheard andrewheard andrewheard approved these changes

Assignees
No one assigned
Labels
api: firebaseai
Projects
None yet
Milestone
Firebase 12 - M167
Development

Successfully merging this pull request may close these issues.
4 participants
@ncooke3 @paulb777 @andrewheard @google-oss-bot
0