8000 Merge 21cd93edf8f99da8316160bfbe3c1b7b1e5f7e3b into aec1dd4ea2b9ccf2b… · firebase/firebase-ios-sdk@fc03b36 · GitHub
[go: up one dir, main page]
Skip to content

Commit fc03b36

Browse files
jeremyjiang-devjeremyjiang-dev
authored
Merge 21cd93e into aec1dd4 
2 parents aec1dd4 + 21cd93e commit fc03b36

File tree

3 files changed

+22
-1
lines changed

3 files changed

+22
-1
lines changed

‎.github/workflows/performance.yml‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,3 +139,21 @@ jobs:
139139
- name: PodLibLint Performance Cron
140140
run: |
141141
scripts/third_party/travis/retry.sh scripts/pod_lib_lint.rb FirebasePerformance.podspec --platforms=${{ matrix.target }} ${{ matrix.flags }}
142+
143+
sanitizers:
144+
# Don't run on private repo unless it is a PR.
145+
if: (github.repository == 'Firebase/firebase-ios-sdk' && github.event_name == 'schedule') || github.event_name == 'pull_request'
146+
runs-on: macos-11
147+
strategy:
148+
matrix:
149+
target: [iOS, tvOS]
150+
test: [unit, proddev]
151+
sanitizer: [asan, tsan, ubsan]
152+
env:
153+
SANITIZERS: ${{ matrix.sanitizer }}
154+
steps:
155+
- uses: actions/checkout@v2
156+
- name: Setup Bundler
157+
run: scripts/setup_bundler.sh
158+
- name: BuildAndTest # can be replaced with pod lib lint with CocoaPods 1.10
159+
run: scripts/third_party/travis/retry.sh scripts/build.sh Performance ${{ matrix.target }} ${{ matrix.test }}

‎FirebasePerformance/CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
11
# Pending
2+
* Fix heap-buffer overflow when encoding sessions. (#8849)
3+
4+
# Version 8.8.0
25
* Create a random number of delay for remote config fetch during app starts.
36
* Fix log spamming when Firebase Performance is disabled. (#8423, #8577)
47
* Fix heap-heap-buffer overflow when decoding strings. (#8628)

‎FirebasePerformance/Sources/FPRNanoPbUtils.m‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,12 +184,12 @@ static firebase_perf_v1_NetworkConnectionInfo_MobileSubtype FPRCellularNetworkTy
184184
perfSessions[perfSessionIndex].session_verbosity_count = 0;
185185
if ((session.options & FPRSessionOptionsEvents) ||
186186
(session.options & FPRSessionOptionsGauges)) {
187+
perfSessions[perfSessionIndex].session_verbosity_count = 1;
187188
perfSessions[perfSessionIndex].session_verbosity =
188189
calloc(perfSessions[perfSessionIndex].session_verbosity_count,
189190
sizeof(firebase_perf_v1_SessionVerbosity));
190191
perfSessions[perfSessionIndex].session_verbosity[0] =
191192
firebase_perf_v1_SessionVerbosity_GAUGES_AND_SYSTEM_EVENTS;
192-
perfSessions[perfSessionIndex].session_verbosity_count = 1;
193193
}
194194
perfSessionIndex++;
195195
}];

0 commit comments

Comments
 (0)
0