8000 fix: avoid android.os.strictmode.UnbufferedIoViolation (resubmission of PR #6565) by gubatron · Pull Request #6822 · firebase/firebase-android-sdk · GitHub
[go: up one dir, main page]
Skip to content

fix: avoid android.os.strictmode.UnbufferedIoViolation (resubmission of PR #6565) #6822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2025
Merged

fix: avoid android.os.strictmode.UnbufferedIoViolation (resubmission of PR #6565) #6822

merged 3 commits into from
Apr 15, 2025

Conversation

gubatron
Copy link
Contributor
  • Wrap InputStream with BufferedInputStream to ensure buffered I/O and prevent UnbufferedIoViolation in Android 14 (SDK 34).
  • Use try-with-resources to automatically close streams, improving resource management.
  • Retain existing functionality for converting InputStream to a UTF-8 string.

This change ensures compliance with Android 14's stricter I/O policies.

@gubatron gubatron mentioned this pull request Mar 29, 2025
Closed
@gubatron
Copy link
Contributor Author

Original Issue: #6564

@lehcar09 lehcar09 requested a review from mrober March 31, 2025 10:07
@davidmotson
Copy link
Collaborator

Hi, unsure if this is a different repo than your previous PR, but remember to add the same Firebase json secret as before to get these test passing!

@gubatron
Copy link
Contributor Author
gubatron commented Apr 4, 2025

same repo, will check the settings. Perhaps I have to recreate the whole firebase secret thing again

@gubatron
fix: avoid android.os.strictmode.UnbufferedIoViolation by using Buffe…
293962b 
…redInputStream

- Wrap InputStream with BufferedInputStream to ensure buffered I/O and
  prevent UnbufferedIoViolation in Android 14 (SDK 34).
- Use try-with-resources to automatically close streams, improving resource management.
- Retain existing functionality for converting InputStream to a UTF-8 string.

This change ensures compliance with Android 14's stricter I/O policies.
@gubatron
Copy link
Contributor Author

rebased and amended commits to be signed.

@davidmotson davidmotson merged commit 19c8c7f into firebase:main Apr 15, 2025
26 of 29 checks passed
@gubatron gubatron deleted the fix/unbuffered-io-violation-android-14-resubmission branch April 21, 2025 22:56
@lehcar09 lehcar09 mentioned this pull request Apr 28, 2025
Closed
@firebase firebase locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrober mrober mrober approved these changes

Assignees
No one assigned
Labels
main-merge-ack size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gubatron @davidmotson @mrober @google-oss-bot
0