Have eval read code from "stdin" when code argument is absent #547
Conversation
src/Dotnet.Script/Program.cs
Outdated
| c.ShowHelp(); | ||
| return 0; | ||
| } | ||
| var source = string.IsNullOrWhiteSpace(code.Value) ? await Console.In.ReadToEndAsync() : code.Value; |
There was a problem hiding this comment.
this is a nice idea, but what if the piped input is not there? it just hangs?
There was a problem hiding this comment.
Yes, just like cat and many other tools that default to receiving content over standard input. That said, I can imagine it being confusing for many. Having the ability to interactively type the input isn't going to be the common case and the experience varies sufficiently (e.g. line editing & EOF) between terminals and platforms that it will only add to the confusion. I have therefore made an update with ee28276 where Console.IsInputRedirected is used to detect if standard input has been redirected and display help otherwise. So now, we are back to the current behaviour where dotnet script eval alone will display help, but if there's code provided as an argument or supplied over standard input, then it's executed.
This is a PR for #546, and while I understand that the idea proposed hasn't been blessed/approved, I thought I'd nonetheless share a PR to demonstrate the minimum changes needed and in case anyone wants to take it for a test drive.