fix(timer): BlynkTimer Broken on Low Memory Ports (blynkkk#6)

BradenM · antohaUa · commit 37df41136113 · 2019-06-20T22:36:15.000+03:00
* fix(timer): BlynkTimer Broken on Low Memory Ports On low memory ports MICROPY_PY_FUNCTION_ATTRS is disabled, leading BlynkTimer to raise an AttributeError when trying to get a name for a new timer. This fixes it by naming each timer 'X_timer' (where X is the # of timer) if the __name__ attribute does not exist. Fixes blynkkk#5 * docs(timer): Added note about Low Memory ports * feat(timer): Cleanup Code, handle all cases * docs(timer): Added some docstrings for clarification
diff --git a/TIMERS.md b/TIMERS.md
@@ -66,8 +66,11 @@ print(blynk_timer.get_timers())
 
 # switch timer state to stopped by timer id
 # id = order_num + '_' + function_name
+# OR: on ports with low memory (such as the esp8266)
+# id = order_num + '_' + 'timer'
 blynk_timer.stop('2_function2')
 
+
 while True:
     intervals = blynk_timer.run()
     # print real passed time for timer fired events
diff --git a/blynktimer.py b/blynktimer.py
@@ -44,9 +44,12 @@ def __init__(self, no_timers_err=True):
         self.no_timers_err = no_timers_err
 
     def _get_func_name(self, obj):
-        if getattr(obj, '__name__', None) is None:
+        """retrieves a suitable name for a function"""
+        if hasattr(obj, 'func'):
+            # handles nested decorators
             return self._get_func_name(obj.func)
-        return obj.__name__
+        # simply returns 'timer' if on port without function attrs
+        return getattr(obj, '__name__', 'timer')
 
     def register(blynk, *args, interval=DEFAULT_INTERVAL, run_once=False, **kwargs):
         class Deco(object):
