10BC0 Add tests for rulemaking comments submission endpoint · Issue #6924 · fecgov/fec-cms · GitHub
[go: up one dir, main page]

Skip to content

Add tests for rulemaking comments submission endpoint #6924

@patphongs

Description

@patphongs

Summary

What we're after:

Test coverage needed:

fec/legal/tests/test_rulemaking_comments.py

  • test_save_comments_requires_POST()
  • test_save_comments_rejects_invalid_json()
  • test_save_comments_validates_recaptcha()
  • test_save_comments_rejects_failed_recaptcha()
  • test_save_comments_validates_file_size() # 5MB limit
  • test_save_comments_rejects_oversized_files() # 413 status
  • test_save_comments_validates_file_types() # .doc, .docx, .pdf, .rtf, .txt, .xls, .xlsx
  • test_save_comments_rejects_invalid_file_types() # 400 status
  • test_save_comments_limits_file_count() # max 3 files
  • test_save_comments_validates_comment_length() # max 4000 chars
  • test_save_comments_requires_comment_or_files()
  • test_save_comments_extracts_commenter_data()
  • test_save_comments_handles_multiple_commenters()
  • test_save_comments_includes_lawfirm_data()
  • test_save_comments_includes_testify_option()
  • test_save_comments_saves_to_s3()
  • test_save_comments_generates_presigned_urls()
  • test_save_comments_returns_submission_id()

Related issues

List any relevant related issue(s)

  • #[issue_number]
  • #[issue_number]

Completion criteria

What does the end state look like? Include any behavior, appearance, etc required for this ticket to be 'complete.'

Tech steps or considerations (optional)

List any considerations the tech team should know. Additionally, any specific tech steps can be included here.

  • First
  • Next
  • Then

Future work

Other future work that may be needed following this issue's completion.

Metadata

Metadata

Assignees

Type

Projects

Status

🗄️ PI backlog

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    0