E400 [FR] Get rid of code duplication which handles RDBMS requests · Issue #1215 · feathr-ai/feathr · GitHub
[go: up one dir, main page]

Skip to content

[FR] Get rid of code duplication which handles RDBMS requests  #1215

@alexander-pv

Description

@alexander-pv

Willingness to contribute

Yes. I can contribute a fix for this bug independently.

Feature Request Proposal

Now one anti-patter stands out quite strongly in the project - code duplication.
I suggest creating small python package to handle RDBMS requests and use it inside atleast sql-registry and access-control packages.

Motivation

What is the use case for this feature?

Reducing the number of anti-patterns in the project (python) will make it easier to maintain and develop by the community.

Details

In the process of studying the project, I made the first version of such package, with extended support for different databases (including PostgreSQL, MariaDB, MySQL): Link. I can open a PR with such change. Additionally, it is worth adding more tests.

What component(s) does this feature request affect?

  • Python Client: This is the client users use to interact with most of our API. Mostly written in Python.
  • Computation Engine: The computation engine that execute the actual feature join and generation work. Mostly in Scala and Spark.
  • Feature Registry API: The frontend API layer supports SQL, Purview(Atlas) as storage. The API layer is in Python(FAST API)
  • Feature Registry Web UI: The Web UI for feature registry. Written in React

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0