-
Notifications
You must be signed in to change notification settings - Fork 85
-
Star 195 8000 div>
Open
Description
| delete params.query.$client; |
While whitelisting is a good security feature, it is the adapter's job to complain about invalid query parameters, not ours.
It makes it difficult to compose hooks with this as it damages the context if used at app level/around/provider and also in services.
Proposal:
const foreignParamCount = 0
// in an Object.keys(ctx.params.query?.$client) loop, foreignParamCount++
if (foreignParamCount === 0) {
delete ctx.params.query.$client
}The alternative is to dump repetitive code like this in all over userland hooks:
delete ctx.params.query.$client.sudo
if (Object.keys(ctx.params.query.$client).length === 0) {
delete ctx.params.query.$client
}Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels