From 38d91296b31b00acea5d0872357ee3df64eb4762 Mon Sep 17 00:00:00 2001 From: deskoh Date: Mon, 15 Apr 2019 14:36:31 +0800 Subject: [PATCH 1/2] Added type definitions for hook-less service methods. --- packages/feathers/index.d.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/packages/feathers/index.d.ts b/packages/feathers/index.d.ts index 9c52f11480..1b4375e568 100644 --- a/packages/feathers/index.d.ts +++ b/packages/feathers/index.d.ts @@ -143,15 +143,27 @@ export interface ServiceMethods { find? (params?: Params): Promise>; + _find? (params?: Params): Promise>; + get? (id: Id, params?: Params): Promise; + _get? (id: Id, params?: Params): Promise; + create? (data: Partial | Array>, params?: Params): Promise; + _create? (data: Partial | Array>, params?: Params): Promise; + update? (id: NullableId, data: T, params?: Params): Promise; + _update? (id: NullableId, data: T, params?: Params): Promise; + patch? (id: NullableId, data: Partial, params?: Params): Promise; + _patch? (id: NullableId, data: Partial, params?: Params): Promise; + remove? (id: NullableId, params?: Params): Promise; + + _remove? (id: NullableId, params?: Params): Promise; } export interface SetupMethod { From 7c14745626ae26214c1ede6a1410562401b27e3c Mon Sep 17 00:00:00 2001 From: deskoh Date: Wed, 22 May 2019 23:44:53 +0800 Subject: [PATCH 2/2] fix: Service typings --- packages/feathers/index.d.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/feathers/index.d.ts b/packages/feathers/index.d.ts index 9e85f9a404..a18ec57c5b 100644 --- a/packages/feathers/index.d.ts +++ b/packages/feathers/index.d.ts @@ -216,7 +216,7 @@ export interface Application extends EventEmitter { setup (server?: any): this; - service (location: L): ServiceTypes[L]; + service (location: L): Service; service (location: string): Service;