8000 empty 'query' object in params argument · Issue #69 · feathersjs/feathers · GitHub
[go: up one dir, main page]

Skip to content

empty 'query' object in params argument #69

@ksmth

Description

@ksmth

Considering the following service:

var Service = {
    find : function (params, callback) {
        // ...
        console.log(params);
    }
};

When called via the REST API the console output is:

GET /users
{ query : {} }

But if you call the same method through a socket connection:

primus.send('users::find', {}, function () {})
{}

In my opinion it should either be {} or { query : {} } in both cases to be consistent, while I think {} would make the most sense.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0